Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable proof hint generation during call to get_exit_code #1153

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

dwightguth
Copy link
Collaborator

Previously, the get_exit_code call would emit events into the proof trace. This is not actually part of the proof of execution though, so we should omit these events.

@rv-jenkins rv-jenkins changed the base branch from master to develop September 30, 2024 16:16
@dwightguth dwightguth marked this pull request as ready for review September 30, 2024 19:47
@theo25 theo25 self-requested a review October 1, 2024 15:35
Copy link
Collaborator

@Robertorosmaninho Robertorosmaninho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rv-jenkins rv-jenkins merged commit 59def8a into develop Oct 1, 2024
10 checks passed
@rv-jenkins rv-jenkins deleted the proof-hint-at-end branch October 1, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants