Introducing new arena and function that allows an object to be ignored by GC #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A c++ unittest is under development, but this was already tested using a K definition for a future K PR. |
dwightguth
reviewed
Sep 3, 2024
There was a problem hiding this comment.
this is a work in progress, obviously, but I added some comments about how you need to adjust this in order to complete it. For more information about how to copy the internal structure of the data types that are handled specially, take a look at runtime/collect/collect.cpp, which has migrate_map, migrate_mpz, etc functions which do a bit different of things than you want to do but do, among other things, copy the entire internal structure of the term to a new arena.
Introducing new function allocation `kore_alloc_forever`
Introducing `hook_KREFLECTION_freeze` function
Robertorosmaninho
force-pushed
the
new-arena-freeze-func
branch
from
016d077
to
ba69af5
Compare
|
Closing as the performance gain isn't meaningful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new Arena and a function to bypass the Garbage Collector, as it may have some times when we don't want to waste time deallocating memory that would be reallocated later for the same data.
The
freezehook function returns the same block with a different allocation in a new Arena.