Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print print intermediate configurations after some function events in kore-proof-trace #1139

Merged
merged 20 commits into from
Sep 17, 2024

Conversation

Robertorosmaninho
Copy link
Collaborator

@Robertorosmaninho Robertorosmaninho commented Aug 23, 2024

This PR introduces a new feature to kore-proof-trace to build a configuration with the contents of a top-level function before its evaluation.

Due to the new way that function arguments are evaluated and printed in the trace before the actual function, I talked with Mircea, and we decided that printing the top-level function with the evaluated arguments would be better than printing all the nested non-evaluated functions.

@Robertorosmaninho Robertorosmaninho self-assigned this Aug 23, 2024
@rv-jenkins rv-jenkins changed the base branch from master to develop August 23, 2024 17:04
@Robertorosmaninho Robertorosmaninho marked this pull request as ready for review September 10, 2024 18:36
@Robertorosmaninho Robertorosmaninho changed the title Print Pre Function Evaluation Configuration in kore-proof-trace Print print intermediate configurations after some function events in kore-proof-trace Sep 10, 2024
@dwightguth
Copy link
Collaborator

Looks good. Have you had a chance to get Mircea to try it and approve of the functionality it provides? if so, it's ok to merge this and mark the task done.

@Robertorosmaninho Robertorosmaninho enabled auto-merge (squash) September 17, 2024 19:23
@Robertorosmaninho Robertorosmaninho merged commit 79677a5 into develop Sep 17, 2024
10 checks passed
@Robertorosmaninho Robertorosmaninho deleted the print-post-function-events branch September 17, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants