Buffered reads/writes for hint generation with shared memory #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robertorosmaninho
approved these changes
Aug 5, 2024
dwightguth
approved these changes
Aug 5, 2024
theo25
force-pushed
the
hints-buffered-shm-io
branch
5 times, most recently
from
ee8d57f
to
e0d8490
Compare
theo25
force-pushed
the
hints-buffered-shm-io
branch
from
e0d8490
to
a5808d5
Compare
theo25
force-pushed
the
hints-buffered-shm-io
branch
from
a5808d5
to
7d09f83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds implementation for buffered reads/writes from and to the shared memory ringbuffer during hint generation. The previous implementation would synchronize reads and writes at the granularity of one byte which is not ideal for performance. In this PR, we add support for synchronization across reads and writes of larger sizes. Both the ringbuffer-based proof trace reader and writer classes are updated to buffer incoming reads and writes: They collect data into an internal buffer and only interacting with the shared memory ringbuffer when that buffer is full in case of the writer or empty in case of the reader.