Shared memory writer for proof hints #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robertorosmaninho
approved these changes
Jul 30, 2024
| set_up_shm_writer(output_filename); | ||
| return; | ||
| } | ||
|
|
||
| output_file = fopen(output_filename, "a"); |
There was a problem hiding this comment.
Should we though about this append mode here? What are your thoughts @theo25 and @dwightguth?
There was a problem hiding this comment.
@dwightguth Any comment on why this has to be an append flag? I kept it as an append because it was like so in the main.ll from where the file open was moved.
dwightguth
changed the title
dwightguth
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a subclass of the abstract
proof_trace_writerfor outputting hints into a ringbuffer that lives in shared memory. This output method is intended to be used with the shared memory option of thekore-proof-traceparser to communicate hints through shared memory instead of through a file.Since we now can test the shared memory based proof generation/consumption loop, we also do not include the helper
kore-proof-trace-shm-writertool in the installation.