Make some code easier to inline (rebased) #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
July 10, 2024 06:03
This is needed because previously we handled these with weak symbols, but the linker can no longer do this for us because everything is now in the same translation unit. Therefore, we reset these functions so that they no longer contain their "default" implementations when they get created by the compiler.
Baltoli
approved these changes
Jul 11, 2024
Comment on lines
-185
to
-210
| if $link; then | ||
| for file in "$LIBDIR"/llvm/*.ll; do | ||
| tmp="$tmpdir/$(basename "$file").o" | ||
| if $visibility_hidden; then | ||
| tmphidden="$tmpdir/$(basename "$file").hidden.bc" | ||
| run @OPT@ "$file" -load-pass-plugin "$set_visibility_hidden" -set-visibility-hidden -o "$tmphidden" | ||
| file="$tmphidden" | ||
| fi | ||
| run @LLC@ \ | ||
| "$file" -mtriple=@BACKEND_TARGET_TRIPLE@ \ | ||
| -filetype=obj "$llc_opt_flags" "${llc_flags[@]}" -o "$tmp" | ||
| files+=("$tmp") | ||
| done | ||
| fi |
lib/codegen/CreateTerm.cpp
Outdated
Comment on lines
30
to
32
| return | ||
| #include "config/llvm_header.h" | ||
| ; |
There was a problem hiding this comment.
I didn't know that this was possible! Awesome!
Robertorosmaninho
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The llvm backend was not being particularly intelligent about the ability to inline certain function calls. Here we move all the
.llfiles in theruntimedirectory into the module used to initialize code generation. This allows these calls to live in one translation unit and be better optimized, while also simplifying llvm-kompile-clang.