Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update name of EventType and expose __repr__ from llvm_rewrite_trace_iterator #1090

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

Robertorosmaninho
Copy link
Collaborator

This small PR only updates the LLVMEventType name to EventType to preserve the LLVM prefix to be used by the wrapper classes created on PyK that export these bindings.

This PR also exposes the __repr__ function of llvm_rewrite_trace_iterator. The print function was already implemented but has yet to be exposed; we decided to expose it as the binding as it can be helpful for debugging.

@Robertorosmaninho Robertorosmaninho added the bindings LLVM backend bindings to other languages label Jun 6, 2024
@Robertorosmaninho Robertorosmaninho self-assigned this Jun 6, 2024
@rv-jenkins rv-jenkins changed the base branch from master to develop June 6, 2024 16:39
@Robertorosmaninho
Copy link
Collaborator Author

Follow up PR: runtimeverification/k#4426

Copy link
Collaborator

@theo25 theo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rv-jenkins rv-jenkins merged commit 30495f7 into develop Jun 6, 2024
10 checks passed
@rv-jenkins rv-jenkins deleted the small-changes-to-pythoon-bindings branch June 6, 2024 18:42
rv-jenkins added a commit to runtimeverification/k that referenced this pull request Jun 12, 2024
This PR exposes the new infrastructure created by the LLVm Backend to
parse the Hints file.
We introduce the wrappers to make the streaming parser possible to use
as a list of events and access it through an integrator. Or not loading
all the events at the same time but accessing them one per time through
the `next()` function.

Depends on:
runtimeverification/llvm-backend#1090

---------

Co-authored-by: rv-jenkins <admin@runtimeverification.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge bindings LLVM backend bindings to other languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants