-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add libunwind as dependency #1081
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but maybe a person more familiar with all the different build options should review this because I cannot tell that these are all the places where the new library needs to be added.
I'm going to mark this as a draft again. I thought I had caught every place where I needed to add this dependency but it looks like I missed some and I'm not going to get to fixing it until tomorrow. |
Where's the failure you're seeing? If this is passing CI but fails elsewhere we should try to catch that scenario. |
I mean, probably the reason it's passing CI is because the library isn't actually used yet, so in the places where I forgot to pass it, nothing bad happens. I don't believe that adding more tests will address that. |
Ah, that makes sense! Let me know when this is ready for a final review and I can take another look at it. |
This is one of a sequence of PRs designed to make progress towards generating stack maps so that we can trigger the GC during allocation rather than in between rewrite steps only. The first few PRs will be preliminaries that add small features that will be used by future PRs.
This PR adds the libunwind library as a runtime dependency to the llvm backend. Libunwind is going to be used by the garbage collector to walk the stack and find the GC roots for each stack frame. The code to actually generate the stack maps and walk the stack will be added in a future PR.