Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add libunwind as dependency #1081

Merged
merged 5 commits into from
Jun 6, 2024
Merged

add libunwind as dependency #1081

merged 5 commits into from
Jun 6, 2024

Conversation

dwightguth
Copy link
Collaborator

This is one of a sequence of PRs designed to make progress towards generating stack maps so that we can trigger the GC during allocation rather than in between rewrite steps only. The first few PRs will be preliminaries that add small features that will be used by future PRs.

This PR adds the libunwind library as a runtime dependency to the llvm backend. Libunwind is going to be used by the garbage collector to walk the stack and find the GC roots for each stack frame. The code to actually generate the stack maps and walk the stack will be added in a future PR.

@rv-jenkins rv-jenkins changed the base branch from master to develop June 3, 2024 16:52
@dwightguth dwightguth marked this pull request as ready for review June 5, 2024 18:36
@dwightguth dwightguth requested review from Baltoli and theo25 June 5, 2024 18:36
Copy link
Collaborator

@theo25 theo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but maybe a person more familiar with all the different build options should review this because I cannot tell that these are all the places where the new library needs to be added.

@dwightguth
Copy link
Collaborator Author

I'm going to mark this as a draft again. I thought I had caught every place where I needed to add this dependency but it looks like I missed some and I'm not going to get to fixing it until tomorrow.

@Baltoli
Copy link
Contributor

Baltoli commented Jun 6, 2024

but it looks like I missed some

Where's the failure you're seeing? If this is passing CI but fails elsewhere we should try to catch that scenario.

@dwightguth
Copy link
Collaborator Author

I mean, probably the reason it's passing CI is because the library isn't actually used yet, so in the places where I forgot to pass it, nothing bad happens. I don't believe that adding more tests will address that.

@Baltoli
Copy link
Contributor

Baltoli commented Jun 6, 2024

Ah, that makes sense! Let me know when this is ready for a final review and I can take another look at it.

@rv-jenkins rv-jenkins merged commit d86e338 into develop Jun 6, 2024
10 checks passed
@rv-jenkins rv-jenkins deleted the unwind branch June 6, 2024 20:02
@Baltoli Baltoli restored the unwind branch June 7, 2024 16:34
@Baltoli Baltoli deleted the unwind branch June 7, 2024 16:34
Baltoli added a commit that referenced this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants