Remove sentinel for end of KORE terms in the proof hint format #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwightguth
approved these changes
May 31, 2024
There was a problem hiding this comment.
This code looks just fine for what it's doing, so I'm approving, but my understanding of the discussed proposed change was the plan to also remove the 0xFFFFFFFFFFFFFFFF word as well. Did that just get miscommunicated or did you try it and discover a reason why it wouldn't actually work to remove?
|
As Theo mentioned on slack, we are keeping the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the sentinel at the end of a KORE terms as it would appear in the proof hint trace. We do not need this sentinel to properly parse the trace because the KORE term binary format includes length information.
The hints version has been bumped to 11 and the relevant tests have been updated.