Add python bindings for proof hint streaming parser #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theo25
approved these changes
May 31, 2024
theo25
approved these changes
May 31, 2024
Baltoli
approved these changes
Jun 3, 2024
Robertorosmaninho
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
LGTM. I would like to see a follow-up PR adding these new bindings in prooftrace.py with appropriate in-line documentation following our current pattern to expose the hints bindings to the Math Proof Generation Team!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we did not have any python bindings for the streaming parser I created.
This PR adds the relevant pybind code as well as adding a python unit test for that code. A slight change is made to the ownership semantics of proof_trace_buffer and its derived classes in order to allow the python bindings to work as expected.