-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exporting kore_symbol
in hook_events
and exposing symbol
entry point in kore_parser
#1064
Conversation
dc2785f
to
8befece
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a big switch-case statement where we parse sentences; is it possible to refactor the code in that part to use this new method?
You will need to bump the hint trace format version here as you're adding new data to the trace. |
I can do it in I've modified the code to use |
Makes sense! |
symbol
entry point to kore_parser
kore_symbol
in hook_events
and exposing symbol
entry point in kore_parser
Co-authored-by: Bruce Collie <brucecollie82@gmail.com>
This PR introduces the new version of the LLVM Backend Proof Hints: Version 10.
The major update is in the
llvm_hook_event
, which will have a new field:kore_symbol
.The new format of hook accepted and produced is:
It also exposes the
symbol
entry point in thekore_parser
.This modification will help the Math Proof Team from Pi2 to parse the
llvm_hook_event->kore_symbol
andllvm_function_event
using the same method.