Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporting kore_symbol in hook_events and exposing symbol entry point in kore_parser #1064

Merged
merged 13 commits into from
May 22, 2024

Conversation

Robertorosmaninho
Copy link
Collaborator

@Robertorosmaninho Robertorosmaninho commented May 21, 2024

This PR introduces the new version of the LLVM Backend Proof Hints: Version 10.

The major update is in the llvm_hook_event, which will have a new field: kore_symbol.
The new format of hook accepted and produced is:

symbol_name       ::= string
hook              ::= WORD(0xAA) name symbol_name location arg* WORD(0xBB) kore_term

It also exposes the symbol entry point in the kore_parser.

This modification will help the Math Proof Team from Pi2 to parse the llvm_hook_event->kore_symbol and llvm_function_event using the same method.

@Robertorosmaninho Robertorosmaninho self-assigned this May 21, 2024
@rv-jenkins rv-jenkins changed the base branch from master to develop May 21, 2024 15:11
Copy link
Contributor

@Baltoli Baltoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a big switch-case statement where we parse sentences; is it possible to refactor the code in that part to use this new method?

@Baltoli
Copy link
Contributor

Baltoli commented May 21, 2024

You will need to bump the hint trace format version here as you're adding new data to the trace.

@Robertorosmaninho
Copy link
Collaborator Author

There's a big switch-case statement where we parse sentences; is it possible to refactor the code in that part to use this new method?

I can do it in application_pattern but not in sentence. The difference is that in the last, we're setting it as hooked or not, and we're using sort_variables(symbol.get()) instead of init_pattern_arguments().

I've modified the code to use symbol in application_pattern .

@Baltoli
Copy link
Contributor

Baltoli commented May 21, 2024

Makes sense!

@Robertorosmaninho Robertorosmaninho changed the title Exposing symbol entry point to kore_parser Exporting kore_symbol in hook_events and exposing symbol entry point in kore_parser May 21, 2024
Robertorosmaninho and others added 2 commits May 22, 2024 09:43
Co-authored-by: Bruce Collie <brucecollie82@gmail.com>
@rv-jenkins rv-jenkins merged commit c61613d into develop May 22, 2024
8 checks passed
@rv-jenkins rv-jenkins deleted the symbol-kore-parser branch May 22, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants