Using map instead of unordered_map to ensure reproducibility of kore definition generation
#1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…definition generation
Baltoli
approved these changes
May 16, 2024
|
Will need formatting to fix CI but otherwise looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen that the
definition.korehas been produced in a different order depending on the OS, which creates a flaky error for some tools likellvm-komplie-compute-ordinalandllvm-kompile-compute-loc, an error on #1053 MacOS tests, and some frontend errors as well.This PR aims to fix that issue by replacing the data structure used to store the attributes.