Implement serialization/deserialization of new algorithm #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 27 commits
May 13, 2024 13:17
dwightguth
force-pushed
the
visit_with_tags
branch
from
2ab625d
to
1a82545
Compare
Robertorosmaninho
requested changes
May 14, 2024
There was a problem hiding this comment.
Overall, it looks good to me. I asked some questions and asked for some comments to understand the code better now and in the future. A small change is needed on the kore-proof-trace. I would also like some // TODO: pointing to the known issue of deserializing inj with the wrong second argument.
Robertorosmaninho
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new version of the proof hint, version 9, which uses the newly created serialization and deserialization functions to serialize terms during the proof hint generation. Not only does this new serialization format take up less memory, it also is roughly 3x faster to serialize.
Note: there is one known issue with this serializer/deserializer: it incorrectly specifies the second sort parameter of the
injsymbol when deserializing. We choose to ignore this known issue due to the fact that this deserializer is being consumed solely by code which transforms the resulting terms into an order-sorted representation by removing the injections entirely.