Fix llvm-kompile pythonast
#1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtrepta
approved these changes
May 8, 2024
|
Yep, they're all good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue experienced by @gtrepta and @theo25 where the Python AST bindings for the LLVM backend incorrectly reference runtime symbols like
FIRST_INJ_TAGwhen loaded.The solution is pretty straightforward; rather than trying to rely on the linker implicitly stripping out undefined symbols when the library is built, we just split the components into two parts (runtime and non-runtime) and selectively include them.
The test case added in 0eb1d7f fails before the script is amended.