Modify side_condition results to be only false or true in Proof Hints
#1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing `emit_serialize_term` with `emit_bool_term` in `side_condition_event_post`
Introducing `result_` in `llvm_side_condition_end_event` Introducing function `parse_bool`
Deleting the check of `kore_end_sentinel` in `ProofTraceParser.h`
Baltoli
suggested changes
Apr 9, 2024
There was a problem hiding this comment.
Some questions and changes. Please also make sure that you accompany any PRs you open with a body that explains the context for the changes. This is important for reviewing now, as well as in the future when we look back at historical changes to try and understand them.
theo25
approved these changes
Apr 9, 2024
Baltoli
approved these changes
Apr 10, 2024
Co-authored-by: Bruce Collie <brucecollie82@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modification was proposed by the LLVM Backend and Math Proof Generation Teams from Pi2 to optimize the Hints generated by the
llvm-krunas constructing and parsing the boolean values of the side conditions takes some time. Then, we choose to simplify the way we're generating these hints.