Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't emit non-exhaustiveness warning if no-evaluators is present #1021

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Don't emit non-exhaustiveness warning if no-evaluators is present #1021

merged 2 commits into from
Apr 8, 2024

Conversation

Scott-Guest
Copy link
Contributor

Closes runtimeverification/k#4148

Updates matching to not emit a warning if the no-evaluators attribute is present.

@Scott-Guest Scott-Guest marked this pull request as ready for review April 4, 2024 03:35
tothtamas28
tothtamas28 approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@tothtamas28 tothtamas28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider writing a test for this.

@Scott-Guest
Copy link
Contributor Author

Consider writing a test for this.

The other exhaustiveness tests are in the frontend, so added one there: runtimeverification/k#4160

@rv-jenkins rv-jenkins merged commit 29463bd into master Apr 8, 2024
8 checks passed
@rv-jenkins rv-jenkins deleted the total-no-evaluators branch April 8, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tothtamas28 tothtamas28 tothtamas28 approved these changes

@gtrepta gtrepta Awaiting requested review from gtrepta

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non-exhaustive match warning on total function with no-evaluators
3 participants
@Scott-Guest @tothtamas28 @rv-jenkins