Adding get_requires() to Python bindings
#1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baltoli
suggested changes
Apr 2, 2024
bindings/python/ast.cpp
Outdated
| @@ -179,7 +179,8 @@ void bind_ast(py::module_ &m) { | |||
| py::arg("is_claim") = false) | |||
| .def_property_readonly("is_claim", &kore_axiom_declaration::is_claim) | |||
| .def("add_pattern", &kore_axiom_declaration::add_pattern) | |||
| .def_property_readonly("pattern", &kore_axiom_declaration::get_pattern); | |||
| .def_property_readonly("pattern", &kore_axiom_declaration::get_pattern) | |||
| .def("get_requires", &kore_axiom_declaration::get_requires); | |||
There was a problem hiding this comment.
This should be a read only property, and shouldn't have the get_ prefix
There was a problem hiding this comment.
Thanks, Bruce! I've just modified it as required!
Baltoli
approved these changes
Apr 2, 2024
rv-jenkins
pushed a commit
to runtimeverification/pyk
that referenced
this pull request
Apr 4, 2024
This PR introduces a new file, `utils.py`, which should contain auxiliary functions that need to be converted from and to llvm but don't set any field on an object. In this context we're using a function from llvm backend's [pattern_matching.cpp](https://github.com/runtimeverification/llvm-backend/blob/e2f583a05b9bf362deabd58f8acc1ce534aaf4c4/lib/ast/pattern_matching.cpp#L174) to avoid reimplement it in Python. This function is exported as Pyhton binding in this [PR](runtimeverification/llvm-backend#1019), and therefore, the current PR can only be merged after we merge the LLVM Backend one. --------- Co-authored-by: devops <devops@runtimeverification.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 9, 2024
This PR introduces a new file, `utils.py`, which should contain auxiliary functions that need to be converted from and to llvm but don't set any field on an object. In this context we're using a function from llvm backend's [pattern_matching.cpp](https://github.com/runtimeverification/llvm-backend/blob/e2f583a05b9bf362deabd58f8acc1ce534aaf4c4/lib/ast/pattern_matching.cpp#L174) to avoid reimplement it in Python. This function is exported as Pyhton binding in this [PR](runtimeverification/llvm-backend#1019), and therefore, the current PR can only be merged after we merge the LLVM Backend one. --------- Co-authored-by: devops <devops@runtimeverification.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 9, 2024
This PR introduces a new file, `utils.py`, which should contain auxiliary functions that need to be converted from and to llvm but don't set any field on an object. In this context we're using a function from llvm backend's [pattern_matching.cpp](https://github.com/runtimeverification/llvm-backend/blob/e2f583a05b9bf362deabd58f8acc1ce534aaf4c4/lib/ast/pattern_matching.cpp#L174) to avoid reimplement it in Python. This function is exported as Pyhton binding in this [PR](runtimeverification/llvm-backend#1019), and therefore, the current PR can only be merged after we merge the LLVM Backend one. --------- Co-authored-by: devops <devops@runtimeverification.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 9, 2024
This PR introduces a new file, `utils.py`, which should contain auxiliary functions that need to be converted from and to llvm but don't set any field on an object. In this context we're using a function from llvm backend's [pattern_matching.cpp](https://github.com/runtimeverification/llvm-backend/blob/e2f583a05b9bf362deabd58f8acc1ce534aaf4c4/lib/ast/pattern_matching.cpp#L174) to avoid reimplement it in Python. This function is exported as Pyhton binding in this [PR](runtimeverification/llvm-backend#1019), and therefore, the current PR can only be merged after we merge the LLVM Backend one. --------- Co-authored-by: devops <devops@runtimeverification.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 10, 2024
This PR introduces a new file, `utils.py`, which should contain auxiliary functions that need to be converted from and to llvm but don't set any field on an object. In this context we're using a function from llvm backend's [pattern_matching.cpp](https://github.com/runtimeverification/llvm-backend/blob/e2f583a05b9bf362deabd58f8acc1ce534aaf4c4/lib/ast/pattern_matching.cpp#L174) to avoid reimplement it in Python. This function is exported as Pyhton binding in this [PR](runtimeverification/llvm-backend#1019), and therefore, the current PR can only be merged after we merge the LLVM Backend one. --------- Co-authored-by: devops <devops@runtimeverification.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 10, 2024
This PR introduces a new file, `utils.py`, which should contain auxiliary functions that need to be converted from and to llvm but don't set any field on an object. In this context we're using a function from llvm backend's [pattern_matching.cpp](https://github.com/runtimeverification/llvm-backend/blob/e2f583a05b9bf362deabd58f8acc1ce534aaf4c4/lib/ast/pattern_matching.cpp#L174) to avoid reimplement it in Python. This function is exported as Pyhton binding in this [PR](runtimeverification/llvm-backend#1019), and therefore, the current PR can only be merged after we merge the LLVM Backend one. --------- Co-authored-by: devops <devops@runtimeverification.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a requirement from the Math Proof Generation Team of$Piˆ2$ to get easy access to the Pattern of a requires clause.
This PR must be merged before this PyK PR that will properly expose this binding to the Pi2 project.