Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency: deps/kevm_release #812

Merged
merged 66 commits into from
Sep 19, 2024

Conversation

rv-jenkins
Copy link
Contributor

@rv-jenkins rv-jenkins commented Sep 6, 2024

Do not merge until #asWord lemmas are also merged in KEVM.

These have now been merged and I've done the appropriate clean-up here. The expected outputs now need to be generated.

@palinatolmach
Copy link
Collaborator

As suggested by @PetarMax and @anvacaru, this PR is not to be merged until #asWord lemmas aren’t upstreamed.

@PetarMax
Copy link
Contributor

PetarMax commented Sep 6, 2024

The tests seem to pass, but I can't guarantee the same for the engagement proofs.

@ehildenb
Copy link
Member

ehildenb commented Sep 7, 2024

That's a pretty good sign that we're missing tests in this test-suite. If we don't have tests that will catch the potential regression downstream, that's a bad sign!

Can we run engagement proofs with this version, and see what breaks, then add appropriate minimized tests (in a separate PR)?

@ehildenb
Copy link
Member

ehildenb commented Sep 7, 2024

It also appears that we don't have -v turned on on integration tests, which can be useful for diagnosing failures on CI without having to re-run locally. Can we do that?

This one likely needs output updated due to: runtimeverification/k#4630

@PetarMax
Copy link
Contributor

There seems to be a conflict in poetry.lock that I'm not sure how to resolve.

@PetarMax
Copy link
Contributor

There is an infinite loop currently in the CSE tests. This PR fixes it.

@anvacaru anvacaru merged commit 098070a into master Sep 19, 2024
13 checks passed
@anvacaru anvacaru deleted the _update-deps/runtimeverification/evm-semantics branch September 19, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants