Encapsulate program-level options #108

nwatson22 · 2023-10-17T23:13:35Z

Adds ProveOptions dataclass for storing the settings that don't change per kontrol prove execution

…ol prove run

tothtamas28

Great refactoring! ✨

src/kontrol/prove.py

src/kontrol/options.py

src/kontrol/prove.py

src/kontrol/__main__.py

src/kontrol/options.py

… args

src/kontrol/prove.py

src/kontrol/options.py

src/kontrol/prove.py

src/tests/integration/test_foundry_prove.py

src/tests/profiling/test_foundry_prove.py

tothtamas28

Looks good!

src/kontrol/options.py

Co-authored-by: Tamás Tóth <tothtamas28@users.noreply.github.com>

Add GlobalOptions class to encapsulate options constant for one kontr…

3e8a0ef

…ol prove run

nwatson22 self-assigned this Oct 17, 2023

devops and others added 3 commits October 17, 2023 23:13

Set Version: 0.1.28

95be5ac

Merge master into branch

029e274

Set Version: 0.1.30

106fe0a

nwatson22 requested review from palinatolmach and tothtamas28 October 18, 2023 20:29

nwatson22 marked this pull request as ready for review October 18, 2023 20:32

tothtamas28 reviewed Oct 19, 2023

View reviewed changes

src/kontrol/prove.py Outdated Show resolved Hide resolved

src/kontrol/options.py Outdated Show resolved Hide resolved

src/kontrol/prove.py Outdated Show resolved Hide resolved

palinatolmach reviewed Oct 19, 2023

View reviewed changes

src/kontrol/__main__.py Outdated Show resolved Hide resolved

src/kontrol/options.py Outdated Show resolved Hide resolved

nwatson22 and others added 6 commits October 19, 2023 14:39

Don't pass options on public function

f820e20

Move options construction to exec_prove, add constructor with default…

434b1b9

… args

Fix typo in help message

e0abfdb

Rename class to ProveOptions

515c080

Merge master into branch

088a5a6

Set Version: 0.1.33

351fdb9

nwatson22 requested review from tothtamas28 and palinatolmach October 19, 2023 21:51

nwatson22 commented Oct 19, 2023

View reviewed changes

src/kontrol/prove.py Outdated Show resolved Hide resolved

Update src/kontrol/prove.py

bb45097

palinatolmach approved these changes Oct 20, 2023

View reviewed changes

palinatolmach added the automerge label Oct 20, 2023

tothtamas28 reviewed Oct 20, 2023

View reviewed changes

tothtamas28 removed the automerge label Oct 20, 2023

tothtamas28 requested a review from palinatolmach October 20, 2023 07:56

nwatson22 and others added 3 commits October 20, 2023 13:01

Address comments

08388a3

Set Version: 0.1.34

2431121

Merge master into branch

f4f2367

tothtamas28 approved these changes Oct 20, 2023

View reviewed changes

src/kontrol/options.py Outdated Show resolved Hide resolved

Update src/kontrol/options.py

fc562a0

Co-authored-by: Tamás Tóth <tothtamas28@users.noreply.github.com>

nwatson22 added the automerge label Oct 20, 2023

rv-jenkins merged commit 132a6c5 into master Oct 21, 2023
8 checks passed

rv-jenkins deleted the noah/store-options branch October 21, 2023 01:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Encapsulate program-level options #108

Encapsulate program-level options #108

nwatson22 commented Oct 17, 2023 •

edited

Loading

tothtamas28 left a comment

tothtamas28 left a comment

Encapsulate program-level options #108

Encapsulate program-level options #108

Conversation

nwatson22 commented Oct 17, 2023 • edited Loading

tothtamas28 left a comment

Choose a reason for hiding this comment

tothtamas28 left a comment

Choose a reason for hiding this comment

nwatson22 commented Oct 17, 2023 •

edited

Loading