Add cheatcode variants that allow introduction of custom K variable names. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enerated variables.
| @@ -31,10 +33,18 @@ interface KontrolCheatsBase { | |||
| function setGas(uint256) external; | |||
| // Returns a symbolic unsigned integer | |||
| function freshUInt(uint8) external returns (uint256); | |||
| // Returns a symbolic unsigned integer with specified K variable name. | |||
| function freshUInt(uint8, string calldata) external returns (uint256); | |||
There was a problem hiding this comment.
Would it make sense to add a similar variant for cheatcodes generating a fresh uint of a specific size, such as this one?
kontrol-cheatcodes/src/KontrolCheats.sol
Line 16 in 7baaf34
There was a problem hiding this comment.
Yes, I added these now. However I found I had to make the string arguments for those memory as opposed to calldata. I was wondering, should these all be memory type, including the ones in IKontrolCheatsBase.sol?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to:
Adds signatures for new cheatcodes corresponding to
symbolicStorageand all thefreshcheatcodes with an additionalstring calldataparameter.The use for this is to allow customized K variable names for the symbolic values in the configuration for ease of interpretation, so you can see based on the name what each symbolic value represents.