Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move nailgun to lib/kframework/bin #3825

Merged
merged 6 commits into from
Nov 29, 2023
Merged

Move nailgun to lib/kframework/bin #3825

merged 6 commits into from
Nov 29, 2023

Conversation

gtrepta
Copy link
Contributor

@gtrepta gtrepta commented Nov 21, 2023

for #3675

@gtrepta
Copy link
Contributor Author

gtrepta commented Nov 21, 2023

@goodlyrottenapple It looks like my change messed up nix somehow, I think it has to do with this snippet here

k/nix/k.nix

Lines 106 to 108 in 41dfa24

preFixup = lib.optionalString (!stdenv.isDarwin) ''
patchelf --set-interpreter "$(cat $NIX_CC/nix-support/dynamic-linker)" "$out/bin-unwrapped/ng"
'';

The error happens on CI here

@gtrepta gtrepta marked this pull request as ready for review November 22, 2023 00:25
Copy link
Collaborator

@dwightguth dwightguth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of changing the path in the setenv script, I would recommend just fully qualifying the path to the binary when it gets invoked.

Copy link
Contributor

@goodlyrottenapple goodlyrottenapple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rv-jenkins rv-jenkins merged commit f708c08 into develop Nov 29, 2023
8 checks passed
@rv-jenkins rv-jenkins deleted the nailgun-location branch November 29, 2023 18:42
@Baltoli Baltoli mentioned this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants