Update dependency: deps/k_release #534
Conversation
This comment was marked as spam.
This comment was marked as spam.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
The switch to using a system-provided |
jberthold
force-pushed
the
_update-deps/runtimeverification/k
branch
from
931529c
to
699cb55
Compare
| @@ -14,6 +14,8 @@ cabal test llvm-integration | |||
|
|
|||
| # The runDirectoryTest.sh script expects the following env vars to be set | |||
| export PLUGIN_DIR=$(nix build github:runtimeverification/blockchain-k-plugin/$PLUGIN_VERSION --no-link --json | jq -r '.[].outputs | to_entries[].value') | |||
| export SECP256K1_DIR=$(nix build nixpkgs#secp256k1 --no-link --json | jq -r '.[].outputs | to_entries[].value') | |||
There was a problem hiding this comment.
This seems to be necessary now... root cause is that we don't actually get a linkable plugin library from including the blockchain-k-plugin, we rather get the sources and have to build things ourselves.
Also see the change to the plugin build and derivation for context.
| "name": "Lbl'Hash'if'UndsHash'then'UndsHash'else'UndsHash'fi'Unds'K-EQUAL-SYNTAX'Unds'Sort'Unds'Bool'Unds'Sort'Unds'Sort", | ||
| "name": "Lblite", |
There was a problem hiding this comment.
This, of course, is a very important name change...
|
|
||
| if [ -z "${server_port}" ]; then | ||
| echo "Unable to identify the server, aborting" | ||
| exit 4 | ||
| else | ||
| echo "Server listening on port ${server_port}" | ||
| fi |
There was a problem hiding this comment.
Previously we would happily continue with an empty server_port variable (garbling the rpc client command).
jberthold
dismissed
geo2a’s stale review
Needs plugin update, currently pointing to a temporary branch
|
Blocked on runtimeverification/blockchain-k-plugin#172
|
Summary by CodeRabbit