207 test tarball runner + tweak rpc client logging #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently successful compilation when providing a PLUGIN_DIR with a checkout of blockchain-k-plugin and NIX_LIBS=... things required to link openssl and procps, outside nix. Should be extended/modified to work within nix
jberthold
commented
Jul 31, 2023
test/rpc-integration/resources/foundry-bug-report.tar.gz.kompile
Outdated
Show resolved
Hide resolved
This reverts commit 49482c4.
Turns out this somehow helps the M1 runner... (???)
jberthold
commented
Aug 1, 2023
| @@ -8,14 +8,18 @@ | |||
| haskell-nix.follows = "haskell-backend/haskell-nix"; | |||
There was a problem hiding this comment.
I noticed that we are testing with a 5.6 version of K here... but upgrading seems to cause issues with the index-state being too new so I left that for a follow-up.
jberthold
commented
Aug 1, 2023
test/rpc-integration/default.nix
Outdated
| @@ -16,7 +16,7 @@ let | |||
| export ${f} | |||
| '') buildFlags} | |||
| export SERVER=${kore-rpc-booster}/bin/kore-rpc-booster | |||
| export CLIENT=${rpc-client}/bin/rpc-client | |||
| export CLIENT="${rpc-client}/bin/rpc-client -l debug" | |||
There was a problem hiding this comment.
I ran with debug logging to analyse the M1 failure but it is flaky... passed on the 2nd run after truncating some output on the first run.
Hopefully this won't become a problem later if/when we merge this.
goodlyrottenapple
approved these changes
Aug 1, 2023
jberthold
deleted the
207-test-tarball-runner_+_tweak-rpc-client-logging
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rpc-client:MonadLoggerand a log-level option^Cor sendingSIGINT)rpc_*directories, with their respective pathFixes #207