Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

text: Take the gutter into account when masking text #18272

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

text: Take the gutter into account when masking text #18272

wants to merge 4 commits into from

Commits on Oct 14, 2024

  1. core: Remove a dangling comment 

    Seems like someone forgot to remove it, it does not apply to anything.
    @kjarosh
    kjarosh committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    b0db5fb View commit details
    Browse the repository at this point in the history

  2. text: Rename INTERNAL_PADDING to GUTTER_WIDTH 

    Adobe documentation refers to the 2px padding as the gutter.
    @kjarosh
    kjarosh committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    2fe5483 View commit details
    Browse the repository at this point in the history

  3. text: Take the gutter into account when masking text 

    Flash Player does not render text over the gutter.
    @kjarosh
    kjarosh committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    61f5c1b View commit details
    Browse the repository at this point in the history

  4. tests: Add edittext_gutter test 

    This test verifies how the gutter of a text field behaves.
    @kjarosh
    kjarosh committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    a42eab9 View commit details
    Browse the repository at this point in the history