Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new ArrayConcatLiteral cop to replace a.concat([1, 2, 3]) with a.push(1, 2, 3) #435

Closed
wants to merge 2 commits into from

Conversation

amomchilov
Copy link

Fixes #434

This PR is stacked on top of commits in #433.

ArrayConcatLiteral synergizes with ArrayPushSingle, so array.concat([x]) will be simplified down to just array << x


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@amomchilov
Copy link
Author

#434 (comment)

@amomchilov amomchilov closed this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cop idea: prefer push(...) over concat([...])
1 participant