Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: detect when being built by github pages for external links #141

Merged
merged 1 commit into from
Feb 14, 2020
Merged

feat: detect when being built by github pages for external links #141

merged 1 commit into from
Feb 14, 2020

Conversation

bguiz
Copy link
Contributor

@bguiz bguiz commented Feb 6, 2020 •
edited
Loading

What

  • detect when being built by github pages for external links

Why

  • Github Pages builds Jekyll using it's own method, doesn't allow customisations, so a Github Pages specific workaround is necessary

Refs

  • Fixes issue #139
  • Follow up for PR: 140

@bguiz bguiz requested a review from ilanolkies February 6, 2020 04:19
@bguiz bguiz changed the title feat: detect when being built by gtihub pages for external links feat: detect when being built by github pages for external links Feb 11, 2020
@bguiz bguiz requested review from a team and solangegueiros and removed request for a team February 14, 2020 06:46
@bguiz bguiz merged commit e5c208c into master Feb 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the feat/href-external-2 branch February 14, 2020 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solangegueiros solangegueiros solangegueiros approved these changes

@ilanolkies ilanolkies Awaiting requested review from ilanolkies

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bguiz @solangegueiros