Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 FIX: Importing from the public folder no longer produces a console error. #12

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

rphlmr
Copy link
Owner

@rphlmr rphlmr commented Oct 21, 2024

Description

Importing assets from the public folder produces a console error

Type of change

Please mark relevant options with an x in the brackets.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Algorithm update - updates algorithm documentation/questions/answers etc.
  • Other (please describe):

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration

  • Integration tests
  • Unit tests
  • Manual tests
  • No tests required

Reviewer checklist

Mark everything that needs to be checked before merging the PR.

  • Check if the UI is working as expected and is satisfactory
  • Check if the code is well documented
  • Check if the behavior is what is expected
  • Check if the code is well tested
  • Check if the code is readable and well formatted
  • Additional checks (document below if any)

Screenshots (if appropriate):

Questions (if appropriate):

Copy link

pkg-pr-new bot commented Oct 21, 2024

Open in Stackblitz

yarn add https://pkg.pr.new/rphlmr/react-router-hono-server@12.tgz

commit: f15a8c2

@rphlmr rphlmr merged commit e33ed37 into main Oct 21, 2024
5 checks passed
@rphlmr rphlmr deleted the fix/public-asset-import branch October 21, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant