Initialize Mailvelope earlier #9243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps fresh users to have a site-specific keyring directly after the first login (see below). And it hurts no one else because the heavy Mailvelope lifting works with Promises, which don't block the main code flow. If Mailvelope's main keyring is not to be used (configurable in Roundcubemail's settings), users with a fresh setup previously had only Mailvelope's main keyring after a login to Roundcubemail. Only after opening an encrypted message, or going to the compose page, they got a site-specific keyring. This lead to some users being confused where the keys went they created after logging in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps fresh users to have a site-specific keyring directly after the first login (see below). And it hurts no one else because the heavy Mailvelope lifting works with Promises, which don't block the main code flow.
If Mailvelope's main keyring is not to be used (configurable in Roundcubemail's settings), users with a fresh setup previously had only Mailvelope's main keyring after a login to Roundcubemail. Only after opening an encrypted message, or going to the compose page, they got a site-specific keyring. This lead to some users being confused where the keys went they created after logging in.