-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(v0.52): SDK v0.52 + gordian integration #192
Draft
Reecepbcups
wants to merge
10
commits into
wip-release/v0.52
Choose a base branch
from
reece/gordian-integration
base: wip-release/v0.52
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reecepbcups
commented
Aug 3, 2024
simapp/v2/simdv2/cmd/root_di.go
Outdated
Comment on lines
56
to
74
cmd = NewRootCmdWithServer(func(cc client.Context) serverv2.ServerComponent[transaction.Tx] { | ||
dc := server.NewDefaultContext() | ||
|
||
var ctx context.Context = context.Background() | ||
ctx = context.WithValue(ctx, client.ClientContextKey, client.Context{ | ||
ChainID: "gcosmos", | ||
HomeDir: "/home/reece/.simappv2", | ||
}) | ||
// ctx = context.WithValue(ctx, server.ServerContextKey, server.NewDefaultContext()) | ||
|
||
log := slog.New(slog.NewJSONHandler(os.Stdout, nil)) | ||
|
||
codec := gtx.NewTxDecoder(cc.TxConfig) | ||
c, err := gserver.NewComponent(ctx, dc, log, codec, cc.Codec) | ||
if err != nil { | ||
panic(err) | ||
} | ||
return c | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ref
* old simapp file movement * simapp v2 -> simapp * base v2 copy paste over * archive * proper embeding and namespace * remote ict in cfg * rm ignite * misc * working: just get a standard namespace to launch with gordian * working with gordian / cometbft selector * simplify selectors into priv methods * helper * embed *.* * todo * fix: latest gordian changes
Reecepbcups
changed the title
feat(v0.52): gordian integration
feat(v0.52): SDK v0.52 + gordian integration
Aug 9, 2024
built off Gordian 4e8efad6985ed80402d0cd807d286c80d8d2f91e for now |
I probably need to just redo this from scratch for a standard SDK v52 base template, with the cleanup from here. Then add Gordian in another PR which stays synced to tip bc v0.52 b unmanageable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gordian-engine/gordian#6
Gordian Simapp Dockerfile