Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate bPoint.py module #747

Open
wants to merge 5 commits into
base: v1
Choose a base branch
from

Conversation

roberto-arista
Copy link
Contributor

Hey there!

Here's the PR for bPoint.py annotations.

A few notes:

  • I get a Signature of "_reprContents" incompatible with supertype "BaseObject" error on _reprContents()
  • I also get a Incompatible types in assignment (expression has type "None", base class "object" defined the type as "Callable[[object], int]") on __hash__
  • I am in doubt on the identifier section. It should be an Optional[str], right?
  • I have used the annotations.CoordinateType to annotate the last four functions at the bottom of the file. Therefore I've used the same type for getters and setters for bcpIn and bpcOut. Should that be the same for getters and setters of the anchor too?

@roberto-arista
Copy link
Contributor Author

cc @knutnergaard

Lib/fontParts/base/bPoint.py Show resolved Hide resolved
Lib/fontParts/base/bPoint.py Outdated Show resolved Hide resolved
Lib/fontParts/base/bPoint.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants