Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note on mutable containers #694

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

roberto-arista
Copy link
Contributor

No description provided.

Add note about mutable containers
@roberto-arista
Copy link
Contributor Author

Not sure why the tests did not work, I've only edited some documentation.
@benkiel @typesupply could you have a look?

@roberto-arista
Copy link
Contributor Author

cc @typemytype

@typemytype
Copy link
Member

two things:

  • I guess we can remove python3.7 for test (not your problem)

  • the other issue is an upload token you probably do not have set on your account: {'detail': ErrorDetail(string='Missing "owner" argument. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}

@benkiel
Copy link
Member

benkiel commented Aug 18, 2023

Yes, it's an issue with fonttools dropping python 3.7. I'm going to merge and fix the tests...

@benkiel benkiel merged commit 119c04e into robotools:master Aug 18, 2023
4 of 8 checks passed
@typemytype
Copy link
Member

thanks Ben!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants