Add compare method to contour, with basic tests. #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #297 +/- ##
==========================================
+ Coverage 70.33% 70.98% +0.65%
==========================================
Files 41 41
Lines 5889 5939 +50
Branches 949 966 +17
==========================================
+ Hits 4142 4216 +74
+ Misses 1609 1579 -30
- Partials 138 144 +6
|
benkiel
commented
May 22, 2018
Lib/fontParts/base/contour.py
Outdated
|
|
||
| if sameStartPoint and samePosition: | ||
| return selfPoints == otherPoints | ||
| elif not sameStartPoint and samePosition: |
There was a problem hiding this comment.
Perhaps this should go, as one could have a two contours with the same points and number of points but different direction or shape (depending on how the contours were connected). The next bit should cover this, I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this looks good, then it can be leveraged to add a compare to Glyph.