Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review included headers, tweak CMake code #72

Closed
PeterBowman opened this issue Jan 17, 2018 · 5 comments
Closed

Review included headers, tweak CMake code #72

PeterBowman opened this issue Jan 17, 2018 · 5 comments
Assignees

Comments

@PeterBowman
Copy link
Member

As a follow up to #56, C++ code should be thoroughly inspected with roboticslab-uc3m/developer-manual#19 in mind. Once all implicit and explicit dependencies are tracked down, CMake code should reflect proper include/link paths and linked libraries (OpenRAVE, YARP, Boost). This also spreads over find_package() calls, i.e. required Boost components.

This is a rather tedious and low priority task.

@PeterBowman
Copy link
Member Author

PeterBowman commented Jan 17, 2018

Idea: cut down the number of search directories for headers (example) by taking advantage of YarpOpenraveBase's transitively included dirs.

Edit: perhaps OpenRAVE compile flags, too?

@PeterBowman
Copy link
Member Author

See recent comments at #62 regarding the YarpOpenraveBase object library.

@PeterBowman
Copy link
Member Author

This also spreads over find_package() calls, i.e. required Boost components.

TODO: set version number in find_package() calls for Boost and OpenRAVE (does OR impose its own Boost version, and is it accessible via CMake config variable?), update install docs.

@PeterBowman PeterBowman self-assigned this Aug 2, 2018
@PeterBowman
Copy link
Member Author

Idea: cut down the number of search directories for headers (example) by taking advantage of YarpOpenraveBase's transitively included dirs.

Edit: perhaps OpenRAVE compile flags, too?

Not doing for now, see #62 (comment).

@PeterBowman
Copy link
Member Author

Done at ebca8bd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant