Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CMake files #56

Closed
PeterBowman opened this issue Dec 24, 2017 · 4 comments
Closed

Refactor CMake files #56

PeterBowman opened this issue Dec 24, 2017 · 4 comments
Assignees
@PeterBowman

Comments

@PeterBowman
Copy link
Member

Much like roboticslab-uc3m/kinematics-dynamics#14 and roboticslab-uc3m/yarp-devices#26.
@PeterBowman PeterBowman self-assigned this Dec 24, 2017
@PeterBowman
Copy link
Member Author

Marking as blocked for the time being to not interfere with ongoing work.

@jgvictores jgvictores mentioned this issue Jan 5, 2018
Closed
PeterBowman added a commit that referenced this issue Jan 16, 2018
@PeterBowman
Clean and refactor CMake files (#56)
214aa06
@PeterBowman
Copy link
Member Author

Almost done at the fix-56-cmake branch, I'm still waiting for Travis to do its job.

@PeterBowman PeterBowman mentioned this issue Jan 17, 2018
Closed
@PeterBowman
Copy link
Member Author

PeterBowman commented Jan 17, 2018 •
edited
Loading

Merged in 114daaf. Now, CMake 2.8.11 or later is required. Apart from the usual cleanup, the InstallOpenravePlugin CMake module has been revamped and is now available for use by clients via find_package (see ROBOTICSLAB_OPENRAVE_YARP_PLUGINSConfig.cmake.in).

Low priority follow up: #72.

@jgvictores
Copy link
Member

Looks really good! @PeterBowman Thanks a lot for these improvements!!

This was referenced Jan 17, 2018
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PeterBowman PeterBowman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jgvictores @PeterBowman