Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare variants for better board manage #182

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

petrkr
Copy link

@petrkr petrkr commented Oct 5, 2024

This PR introduce variants folder and include this folder in platformio.ini

That will make easier managing of existing and new boards. Also if someone add own board to platformio.ini and you will make changes, it will NOT conflict after this change, because it will be untracked new folder inside variants folder, so any changes to other boards (like now ePaper ones) will NOT cause conflicts during rebase to latest master

In next step is move all boards from platformio.ini to variants, but for now this is minimum to make possible to do for new boards. Old ones can be moved momentary.

There are lot of boards, so it will take lot of work to move them all. But since it is include not change, then it can be done one-by-one but not need to at once..

I will show in next PR example with moved few boards.

@richonguzman
Copy link
Owner

so a variants folder will be created to mange all the future boards?

meshtastic kind of doing things ?

@petrkr
Copy link
Author

petrkr commented Oct 5, 2024

Yes, not only meshtastic, I saw it at other platformio projects too and it is kind of good idea I think. Especially if you want add boards and you do not want anytime solve conflicts in one huge platformio.ini

@petrkr
Copy link
Author

petrkr commented Oct 5, 2024

Ah that folder was not commited to GIT, because it is empty. So that is reason why everyone put .gitkeep files into empty folders :)

@petrkr
Copy link
Author

petrkr commented Oct 5, 2024

Here is commit with moved boards to variants folder

petrkr@c266a25

@petrkr
Copy link
Author

petrkr commented Oct 19, 2024

Rebased to latest master. Due adding of NTP library I had to do it again, because it again conflicts.

Btw I added NTP Client too few weeks ago to ethernet version :) So it will conflict me too.. But your implementation is better. I just turned on NTP Client and not did anything longer, as had no time now

@richonguzman
Copy link
Owner

So, I need to talk to you on Telegram to understand a few things about this variants (which is really awesome idea to get this right and be easy to add more and more boards as they come)

also need some help with a little ntp bug I found

Signed-off-by: Petr Kracík <petrkr@petrkr.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants