Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Borealis Theme #21

Draft
wants to merge 23 commits into
base: master
Choose a base branch
from
Draft

Add Borealis Theme #21

wants to merge 23 commits into from

Conversation

QazCetelic
Copy link

No description provided.

@QazCetelic
Copy link
Author

Settings-Appearance
Channel-Preview

@aeristhy
Copy link
Contributor

I should link you up to this comment right here


This is fine for the most part but there are two issues with the custom background:

  • Hot-linking to external third party service.

  • I'd probably need to have a license to use this artwork? Since I'd imagine it's protected under copyright law.

Not sure how to go about resolving either.

@QazCetelic
Copy link
Author

QazCetelic commented Nov 22, 2021

@aeristhy
The image is loaded from the Pixabay CDN, Pixabay provides free images & royalty free stock. The image is therefore licensed under the Pixabay License, which allows usage even without attribution.

The hot linking is definitely an issue though, would it be possible to allow adding an media folder to a theme to store content like this?

@QazCetelic
Copy link
Author

I just checked it and the revolt servers will have to store the media.

NO HOTLINKING - what does that mean?
If you want to show Pixabay media on your website, please upload them to your server. Pixabay media URLs don't work on external sites.

@aeristhy
Copy link
Contributor

I see, this should fix issues Insert was worried about(I think)

@QazCetelic
Copy link
Author

I see, this should fix issues Insert was worried about(I think)

I opened an issue (#24) to add a media folder so that this theme can be added.

@insertish insertish added the draft This issue needs more work label Jan 3, 2022
@QazCetelic
Copy link
Author

The background image is embedded into the CSS now.

@QazCetelic
Copy link
Author

@insertish I think it's valid now, I found a work-around without needing the media folder.

@insertish
Copy link
Member

This does create a new problem in the fact that the custom CSS file is 127 kB now.

I would either:

  • Wait for discovery system to be changed to only load preset file for preview.
  • Wait for media folder issue to be resolved.
  • Host the image on Revolt; upload to Saved Notes.

@QazCetelic
Copy link
Author

The image is now hosted on Revolt.

Copy link
Member

@Rexogamer Rexogamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor points:

data/borealis/Custom.css Outdated Show resolved Hide resolved
data/borealis/Custom.css Outdated Show resolved Hide resolved
data/borealis/Custom.css Outdated Show resolved Hide resolved
data/borealis/Preset.toml Outdated Show resolved Hide resolved
QazCetelic and others added 5 commits January 20, 2022 18:38
Co-authored-by: Ed L <beartechtalks@gmail.com>
Co-authored-by: Ed L <beartechtalks@gmail.com>
Co-authored-by: Ed L <beartechtalks@gmail.com>
Co-authored-by: Ed L <beartechtalks@gmail.com>
@QazCetelic
Copy link
Author

@insertish It should be valid now

@QazCetelic
Copy link
Author

@insertish will this be merged?

@Rexogamer
Copy link
Member

The custom CSS will likely need to be updated

@insertish insertish removed the draft This issue needs more work label Jan 24, 2023
@insertish insertish marked this pull request as draft January 24, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants