Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input for setting detect-secrets version #58

Merged
merged 4 commits into from
Feb 14, 2024
Merged

Conversation

javierjulio
Copy link
Contributor

Since detect-secrets can emit several false positives, like the other reviewdog actions, it would help to be able to specify an explicit detect-secrets version as an input. Only option here is to install the latest which can change with a new release. Ideally, we would set a hard coded default version for detect-secrets but that may not be a change we want to implement right now.

Closes #36

@javierjulio javierjulio self-assigned this Feb 13, 2024
Copy link
Contributor

🏷️ [bumpr] Next version:v0.18.0 Changes:v0.17.0...reviewdog:javierjulio-patch-1

@haya14busa haya14busa merged commit 1a35133 into master Feb 14, 2024
5 checks passed
Copy link
Contributor

🚀 [bumpr] Bumped! New version:v0.18.0 Changes:v0.17.0...v0.18.0

@javierjulio javierjulio deleted the javierjulio-patch-1 branch February 14, 2024 22:33
@javierjulio
Copy link
Contributor Author

@haya14busa sorry, this wasn't intended for release as I was testing this idea out. Sadly, the new input doesn't work here based on the logs. It doesn't seem that there's a way to specify a detect-secrets version that gets picked up in the Dockerfile on building the image. I was trying the runs.env block but noticed it didn't work and figured I'd come back to it the next day. Sorry about that confusion.

I guess for now we can just consider the input as non-functional and consider removing in v1 if ever released, unless we can figure out how to support a version parameter. From reviewing other reviewdog actions, my hunch is this would have to use an actions/setup-python combo with a shell script to install the specified detect-secrets version, like actions-rubocop or actions-brakeman.

@haya14busa
Copy link
Member

Ok. Let's revert the change.

haya14busa added a commit that referenced this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify detect-secrets version to be used
2 participants