Improve grammar installation #230
Conversation
update queries structure, add native nvim-treesitter.parsers instructions
TheFedaikin
changed the title
TheFedaikin
changed the title
|
Hello @TheFedaikin. Thanks for the contribution! Although I shallowly understand the good intent, it will likely break the integration of this and the https://github.com/nkrkv/nvim-treesitter-rescript repo. I need some time to carefully review the changes and the consequences. Please, give me some time, I’m OOO until September. |
|
Hey @nkrkv! In a way I think this basically streamlines the installation and deprecates https://github.com/nkrkv/nvim-treesitter-rescript for everyone who uses NeoVim in an opinionated way, favoring native custom parser with neovim-treesitter. I completely understand your point of a view and, as I alluded to, in the initial message I have no problem with this being closed, because it's not needed. There's no rush to this, since I can just maintain my fork and install it locally for my needs. Have a good vacation! |
|
|
||
| This will make `TSInstall rescript` globally available. For more persistent approach you should add this parser to your Lua configuration. | ||
|
|
||
| Default configuration detects `.res` and `.resi` files. You can confirm that it's correctly installed by using [`nvim-treesitter/playground`](https://github.com/nvim-treesitter/playground) and invoking `TSPlaygroundToggle` when you are in the ReScript file. |
There was a problem hiding this comment.
Since Neovim 0.9 the command :InspectTree is available to inspect the tree.
There was a problem hiding this comment.
Will update it!
| install_info = { | ||
| url = "https://github.com/nkrkv/tree-sitter-rescript", | ||
| branch = "main", | ||
| files = { "src/scanner.c" }, |
There was a problem hiding this comment.
I think parser.c should be added?
| files = { "src/scanner.c" }, | |
| files = { 'src/parser.c', 'src/scanner.c' }, |
There was a problem hiding this comment.
I think it's needed explicitly when this file is present, since it's not I don't think so. To support this I have my forked branch installed basically like this
{
"nvim-treesitter/nvim-treesitter",
dependencies = {
{
"TheFedaikin/tree-sitter-rescript",
},
},
opts = function(_, opts)
vim.list_extend(opts.ensure_installed, {
"rescript",
})
local parser_config = require("nvim-treesitter.parsers").get_parser_configs()
parser_config.rescript = {
install_info = {
url = "https://github.com/TheFedaikin/tree-sitter-rescript",
branch = "main",
files = { "src/scanner.c" },
generate_requires_npm = false,
requires_generate_from_grammar = true,
use_makefile = true, -- macOS specific instruction
},
}
end,
},And it works wonders
|
Closed by #239 |
Hello package maintainers!
First of all I wanted to say thanks for creating this grammar!
I've been tinkering with rescript lately and had a couple of issues installing it via currently recommended way while using
lazy.nvim. I created a local fork to streamline this process and avoid manually adding the queries into my config. While doing so I thought that this can greatly help people who are using modern NeoVim, but maybe are struggling to figure out how to install this grammar. This is how this PR was born.If this is not welcome, please let me know I'll close this PR immediately and will just keep it for myself.
Description:
READMEwith new instructions and example of simplified installation until this grammar is upstreamed.Partially related to #203.
All the feedback is welcome, especially considering the instructions.