Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: use the latest beta. #777

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Tests: use the latest beta. #777

wants to merge 1 commit into from

Conversation

cristianoc
Copy link
Collaborator

No description provided.

@cristianoc cristianoc requested a review from zth May 26, 2023 00:55
@cristianoc
Copy link
Collaborator Author

@zth this uses the latest beta, which has uncurried on by default.
The tests show things that still need to be taken care of.

@cristianoc cristianoc mentioned this pull request May 26, 2023
Open
@cristianoc
Copy link
Collaborator Author

For a set of changes excluding uncurried, see here: #778

@zth
Copy link
Collaborator

zth commented May 27, 2023

I assume most of these have to do with us not accounting for not setting uncurried at all in bsconfig.json now implicitly means uncurried: true, where it used to mean uncurried: false?

@cristianoc
Copy link
Collaborator Author

I assume most of these have to do with us not accounting for not setting uncurried at all in bsconfig.json now implicitly means uncurried: true, where it used to mean uncurried: false?

Good point. I was not thinking about that. Maybe that's just it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zth zth Awaiting requested review from zth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cristianoc @zth