Exotic identifiers #710
Open
Exotic identifiers #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zth
reviewed
Jan 23, 2023
Comment on lines
+1093
to
+1096
| let fname = | ||
| PrintType.printIdentLike ~allowUident:false field.fname.txt | ||
| in | ||
| Completion.create fname |
There was a problem hiding this comment.
One idea is to not use the name field for this, but instead the insertText field. That'll make the name appear normal in the completion list, but it's the escaped identifier that'll be insterted. What do you think?
There was a problem hiding this comment.
We can also consider whether this should be done inside of Completion.create directly. Probably not though, as there are quite a few instances where it shouldn't be escaped even when there are exotic characters in there (like with variant payloads, Some(whatver)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some test cases for #598.
So far, I was able to fix only a part of them and could use help with the rest.