Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ChunkStore::drop_time_range #7602

Merged
merged 6 commits into from
Oct 7, 2024
Merged

Add ChunkStore::drop_time_range #7602

merged 6 commits into from
Oct 7, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Oct 6, 2024 •
edited by github-actions bot
Loading

What

Adds ChunkStore::drop_time_range to drop all events within some time range. Will be used to implement undo.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added ⛃ re_datastore affects the datastore itself exclude from changelog PRs with this won't show up in CHANGELOG.md labels Oct 6, 2024
@emilk emilk mentioned this pull request Oct 6, 2024
Draft
11 tasks
@teh-cmc teh-cmc self-requested a review October 7, 2024 07:31
teh-cmc
teh-cmc approved these changes Oct 7, 2024
View reviewed changes
crates/store/re_chunk/src/chunk.rs
/// Returns a version of us with a new id
#[must_use]
#[inline]
pub fn with_id(mut self, id: ChunkId) -> Self {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am almost tempted to mark this unsafe... Duplicated RowIds in the ChunkStore is straight up UB.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a reminder in the doc comment.

@teh-cmc teh-cmc merged commit 8702f01 into main Oct 7, 2024
20 checks passed
@teh-cmc teh-cmc deleted the emilk/drop-time-range branch October 7, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teh-cmc teh-cmc teh-cmc approved these changes

Assignees
No one assigned
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md ⛃ re_datastore affects the datastore itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilk @teh-cmc