Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo (and redo) in viewer #3135

Open
roym899 opened this issue Aug 29, 2023 · 0 comments · May be fixed by #7546
Open

Undo (and redo) in viewer #3135

roym899 opened this issue Aug 29, 2023 · 0 comments · May be fixed by #7546
Assignees
@emilk
Labels
🟦 blueprint The data that defines our UI enhancement New feature or request ui concerns graphical user interface
Milestone
Triage

Comments

@roym899
Copy link
Collaborator

roym899 commented Aug 29, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
Sometimes I accidentally remove a space view, making it quite annoying to set it up again.
Similarly, sometimes I move a view around which destroys the tiling, but there's no way to undo without setting everything up from scratch.

Describe the solution you'd like
Undoing changes in the viewer (like removing and moving a view) with Ctrl+Z.

Redo would be nice to have as well, but not as important.

Related to #1132.
@roym899 roym899 added enhancement New feature or request 👀 needs triage This issue needs to be triaged by the Rerun team labels Aug 29, 2023
@nikolausWest nikolausWest added ui concerns graphical user interface 🟦 blueprint The data that defines our UI and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Aug 29, 2023
@emilk emilk added this to the Triage milestone Aug 5, 2024
@emilk emilk self-assigned this Sep 29, 2024
This was referenced Sep 29, 2024
Draft
Merged
Merged
teh-cmc pushed a commit that referenced this issue Oct 7, 2024
@emilk
ChunkStore: Protect specific time ranges during GC (#7603)
899b17b 
### What
* Part of #3135

This lets us protect a specific time range from being garbage-collected.

This will be used to implement undo, in order to protect the latest N
undo points (e.g. the latest 100, if we have max-undo=100).
teh-cmc added a commit that referenced this issue Oct 7, 2024
@emilk @teh-cmc
Add ChunkStore::drop_time_range (#7602)
8702f01 
### What
Adds `ChunkStore::drop_time_range` to drop all events within some time
range. Will be used to implement undo.

* Part of #3135
* Extracted from #7546

---------

Co-authored-by: Clement Rey <cr.rey.clement@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilk emilk

Labels
🟦 blueprint The data that defines our UI enhancement New feature or request ui concerns graphical user interface
Projects
None yet
Milestone
Triage
Development

Successfully merging a pull request may close this issue.

Add Undo/Redo support in the viewer rerun-io/rerun
3 participants
@emilk @nikolausWest @roym899