Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: react-dapp-v2 updated for Tezos #695

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dianasavvatina
Copy link

Updated for Tezos:

  • fixed RPC addresses
  • added command parameters and result in the modal for better user experience
  • added examples for contract calls, delegation, stake, unstake, finalize and more
  • added balance and token metadata
  • clarified logs

Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vue-web-examples ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 2:13pm

Copy link

vercel bot commented Sep 5, 2024

@dianasavvatina is attempting to deploy a commit to the WalletConnect Team on Vercel.

A member of the Team first needs to authorize it.

@dianasavvatina
Copy link
Author

@Cali93, hello! How can I reach you to discuss adaptation for Tezos? I created a number of draft PRs and I wonder if my solution is correct. Do you have Slack? Or maybe you can reach me in Twitter (@savvadia)?

Updated for Tezos:
 - fixed RPC calls
 - fixed modals for better user experience
 - added examples for contract calls, delegation, and more
 - added balance and token metadata
@Cali93
Copy link
Contributor

Cali93 commented Sep 20, 2024

Hey @ganchoradkov, could you help @dianasavvatina with this please ?

Copy link
Member

@ganchoradkov ganchoradkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome PR! Thank you improving the Tezos implementation example. 💯
I have only one remark regarding tezos methods constants, once fixed we should be good to merge 💯

@@ -48,6 +48,7 @@ import {
DEFAULT_MULTIVERSX_METHODS,
DEFAULT_TRON_METHODS,
DEFAULT_TEZOS_METHODS,
TEZOS_SAMPLE_KINDS,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we bundle TEZOS_SAMPLE_KINDS and DEFAULT_TEZOS_METHODS into single prop DEFAULT_TEZOS_METHODS so we can keep the current app convention and reduce complexity of handling two method sources

Copy link
Author

@dianasavvatina dianasavvatina Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ganchoradkov, Tezos has default methods (tezos_getAccounts, tezos_sign, tezos_send) which are used when establishing a connection.
the tezos_send method is used nearly for all possible Tezos operations: transaction, origination, delegation, staking, calling smart contracts, etc. So to make an example for Tezos I added a number of sample operations to show how they should look like.
As a result, I have 2 lists of operations:

  • DEFAULT_TEZOS_METHODS for 3 allowed methods
  • TEZOS_SAMPLE_KINDS a list of methods extended with multiple kinds for tezos_send. This list is used to show the list of buttons for Tezos operations.

I bundled them now. Hope it looks better now

@dianasavvatina
Copy link
Author

@ganchoradkov please take a look. I applied comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants