fix: dynamic chain support #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris13524
force-pushed
the
fix/dynamic-chain-support
branch
from
228f017
to
7119c30
Compare
This was referenced Mar 8, 2024
chris13524
commented
Mar 8, 2024
| ) | ||
| .await | ||
| { | ||
| error!("Failed to refresh supported chains: {e}"); |
There was a problem hiding this comment.
Ideally we could get service-level metrics, alarms, etc. for this error, but would take more refactoring and not a big deal anyway because this type of temporary error is non-actionable and we test this code path on app startup.
nopestack
reviewed
Mar 11, 2024
| Address::from_str(&address).map_err(|_| CacaoError::AddressInvalid)?, | ||
| &hash.finalize()[..] | ||
| .try_into() | ||
| .expect("hash length is 32 bytes"), |
There was a problem hiding this comment.
Because the Keccak256 hash length is always 32 bytes
nopestack
approved these changes
Mar 11, 2024
geekbrother
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dynamically supports chains that Blockchain API says it supports via this new API. Supported chains are obtained on server startup, and refreshed every 4 hours.
This PR also extracts the Blockchain API functions out of the
relay_rpccrate into a new crate because they depend on thetokiodependency which was only a dev-dependency.This PR also makes the Blockchain API endpoint configurable rather than hardcoded. This is a best practice, but also enables the ability to disable the Blockchain API provider during testing (it's disabled in integration tests) which is good because it's not used anyway and also reduces dependency on Internet services for local development.
How Has This Been Tested?
Manually by running the Notify Server and Keys Server PRs that depend on this locally. Created a custom test case which uses an identity key and signed CACAO extracted from developer tools of running app.web3inbox.com which I created with Argent wallet.
Due Diligence