Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure test quality via linting #19

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Ensure test quality via linting #19

merged 1 commit into from
Nov 6, 2023

Conversation

akosthekiss
Copy link
Collaborator

  • List standard modules first in imports.
  • Use dict literals.
  • Use with when opening files.
  • Don't specify object as superclass.

@akosthekiss
Ensure test quality via linting
f6287c9 
- List standard modules first in imports.
- Use dict literals.
- Use with when opening files.
- Don't specify object as superclass.
renatahodovan
renatahodovan approved these changes Nov 6, 2023
View reviewed changes
Copy link
Owner

@renatahodovan renatahodovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@renatahodovan renatahodovan merged commit 3f02019 into renatahodovan:master Nov 6, 2023
23 checks passed
@akosthekiss akosthekiss deleted the lint-tests branch November 6, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatahodovan renatahodovan renatahodovan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akosthekiss @renatahodovan