Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v23.3.x] rptest: assert consumer invariants after each upgrade #23883

Open
wants to merge 2 commits into
base: v23.3.x
Choose a base branch
from
Open

[v23.3.x] rptest: assert consumer invariants after each upgrade #23883

wants to merge 2 commits into from
+13 −6

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #23876

@nvartolomei @vbotbuildovich
rptest: use a numerical initial value to avoid type checking errors
0c5f8a6 
(cherry picked from commit 40b7db7)
@nvartolomei @vbotbuildovich
rptest: assert consumer invariants after each upgrade
ea690e5 
This improves failure result fidelity because we would spot the error
exactly after a bad upgrade rather than at the end of the test.

This also makes it simple(r) to skip validating old versions of
redpanda with newer versions of consumers which check additional
invariants.

This is to prepare for upgrading kgo to a version where it crashes
instantly on data loss on upgrade through some old versions of Redpanda
(around v21, v22). I plan to skip validating these versions and focus
only on latest supported releases instead.

(cherry picked from commit 790af4b)
@vbotbuildovich vbotbuildovich added this to the v23.3.x-next milestone Oct 22, 2024
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Oct 22, 2024
@vbotbuildovich
Copy link
Collaborator Author

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/57023#0192b59d-d190-4791-a8e5-f46b88c7c026

@vbotbuildovich
Copy link
Collaborator Author

Retry command for Build#57023

please wait until all jobs are finished before running the slash command

/ci-repeat 1
tests/rptest/tests/rpk_cluster_test.py::RpkClusterTest.test_upload_and_query_cluster_license_rpk

@vbotbuildovich
Copy link
Collaborator Author

the below tests from https://buildkite.com/redpanda/redpanda/builds/57023#0192b566-ff9c-430e-a03c-5454f9ea35b6 have failed and will be retried

cluster_cloud_metadata_rpfixture
kafka_server_rpfixture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvartolomei nvartolomei Awaiting requested review from nvartolomei

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v23.3.x-next
Development

Successfully merging this pull request may close these issues.
2 participants
@vbotbuildovich @nvartolomei