Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug_bundle: fix flaky test #23841

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

debug_bundle: fix flaky test #23841

wants to merge 1 commit into from
+58 −21

Conversation

IoannisRP
Copy link
Contributor

@IoannisRP IoannisRP commented Oct 18, 2024 •
edited by jira bot
Loading

Fixes: CORE-7839

The querying for debug bundle metrics happened directly after the service generation. Occasionally, this led to retrieving stale data. To protect against this, a waiting period has been added when trying to get updated metrics.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.2.x
  • v24.1.x
  • v23.3.x

Release Notes

  • none

@IoannisRP IoannisRP requested review from michael-redpanda and a team October 18, 2024 19:13
@IoannisRP IoannisRP marked this pull request as ready for review October 18, 2024 19:16
dotnwat
dotnwat reviewed Oct 18, 2024
View reviewed changes
tests/rptest/tests/debug_bundle_test.py
@@ -257,41 +257,78 @@ def test_debug_bundle_metrics(self):
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a waiting period when trying to get updated metrics.

please add to the commit message what the problem was and how waiting fixes it.

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Oct 18, 2024 •
edited
Loading

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/56834#0192a155-370f-43fd-b70a-7b6883b316e8
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/56911#0192aedc-ad87-4b07-a813-ea43267fd011
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/56911#0192aee0-f5ca-4477-bb88-a48e821567a5
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/56911#0192aee0-f5cc-4a56-ac68-9a3690ca3b38
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/56911#0192aee0-f5ce-4afb-8427-c2a64ce4c498

@vbotbuildovich
Copy link
Collaborator

Retry command for Build#56834

please wait until all jobs are finished before running the slash command

/ci-repeat 1
tests/rptest/tests/rpk_cluster_test.py::RpkClusterTest.test_upload_and_query_cluster_license_rpk

BenPope
BenPope reviewed Oct 21, 2024
View reviewed changes
Copy link
Member

@BenPope BenPope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IoannisRP
debug_bundle: fix flaky test
78ad592 
The querying for debug bundle metrics happened directly after the
service generation. Occasionally, this led to retrieving stale data.
To protect against this, a waiting period has been added when trying
to get updated metrics.
@IoannisRP
Copy link
Contributor Author

Updated commit message

@dotnwat
Copy link
Member

dotnwat commented Oct 21, 2024

Updated commit message

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenPope BenPope BenPope approved these changes

@michael-redpanda michael-redpanda michael-redpanda approved these changes

@dotnwat dotnwat Awaiting requested review from dotnwat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@IoannisRP @vbotbuildovich @dotnwat @BenPope @michael-redpanda