Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kgo: record all records and validate leader epoch monotonicity #23838

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

nvartolomei
Copy link
Contributor

https://github.com/redpanda-data/kgo-verifier/pull/58/commits

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.2.x
  • v24.1.x
  • v23.3.x

Release Notes

  • none

@nvartolomei nvartolomei requested a review from a team as a code owner October 18, 2024 15:19
@nvartolomei nvartolomei requested review from andrewhsu and removed request for a team October 18, 2024 15:19
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Oct 18, 2024

non flaky failures in https://buildkite.com/redpanda/redpanda/builds/56825#0192a076-cdc7-478f-94b9-0ba402665ce3:

"rptest.tests.shard_placement_test.ShardPlacementTest.test_node_join"
"rptest.tests.tiered_storage_model_test.TieredStorageTest.test_tiered_storage.cloud_storage_type_and_url_style=.CloudStorageType.S3.1.virtual_host.test_case=.TS_Read==True.TS_TxRangeMaterialized==True.SpilloverManifestUploaded==True"

non flaky failures in https://buildkite.com/redpanda/redpanda/builds/56825#0192a076-cdc5-4485-b2a6-934cfb6d7a6f:

"rptest.tests.shard_placement_test.ShardPlacementTest.test_manual_rebalance"

non flaky failures in https://buildkite.com/redpanda/redpanda/builds/56825#0192a07a-f5b7-4af5-a800-b56aaf948bab:

"rptest.tests.e2e_shadow_indexing_test.ShadowIndexingWhileBusyTest.test_create_or_delete_topics_while_busy.short_retention=True.cloud_storage_type=CloudStorageType.S3"
"rptest.tests.shard_placement_test.ShardPlacementTest.test_node_join"

non flaky failures in https://buildkite.com/redpanda/redpanda/builds/56825#0192a07a-f5b6-48bb-a3ef-60a97e1caa23:

"rptest.tests.e2e_shadow_indexing_test.ShadowIndexingWhileBusyTest.test_create_or_delete_topics_while_busy.short_retention=True.cloud_storage_type=CloudStorageType.ABS"

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Oct 18, 2024

Retry command for Build#56825

please wait until all jobs are finished before running the slash command

/ci-repeat 1
tests/rptest/tests/shard_placement_test.py::ShardPlacementTest.test_node_join
tests/rptest/tests/tiered_storage_model_test.py::TieredStorageTest.test_tiered_storage@{"cloud_storage_type_and_url_style":[1,"virtual_host"],"test_case":{"name":"(TS_Read == True, TS_TxRangeMaterialized == True, SpilloverManifestUploaded == True)"}}
tests/rptest/tests/shard_placement_test.py::ShardPlacementTest.test_upgrade
tests/rptest/tests/consumer_offsets_consistency_test.py::ConsumerOffsetsConsistencyTest.test_flipping_leadership
tests/rptest/tests/shard_placement_test.py::ShardPlacementTest.test_manual_rebalance
tests/rptest/tests/upgrade_test.py::UpgradeBackToBackTest.test_upgrade_with_all_workloads@{"single_upgrade":false}
tests/rptest/tests/e2e_shadow_indexing_test.py::ShadowIndexingWhileBusyTest.test_create_or_delete_topics_while_busy@{"cloud_storage_type":1,"short_retention":true}
tests/rptest/tests/e2e_shadow_indexing_test.py::ShadowIndexingWhileBusyTest.test_create_or_delete_topics_while_busy@{"cloud_storage_type":2,"short_retention":true}
tests/rptest/tests/e2e_shadow_indexing_test.py::ShadowIndexingWhileBusyTest.test_create_or_delete_topics_while_busy@{"cloud_storage_type":2,"short_retention":false}
tests/rptest/tests/e2e_shadow_indexing_test.py::ShadowIndexingWhileBusyTest.test_create_or_delete_topics_while_busy@{"cloud_storage_type":1,"short_retention":false}
tests/rptest/tests/workload_upgrade_runner_test.py::RedpandaUpgradeTest.test_workloads_through_releases@{"cloud_storage_type":1}

@nvartolomei nvartolomei force-pushed the nv/kgo-monotonic-terms branch 2 times, most recently from aa1a763 to 13a5664 Compare October 21, 2024 14:38
Copy link
Member

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i suggest this PR block on merge of redpanda-data/kgo-verifier#58

@@ -2,6 +2,6 @@
set -e
git -C /opt clone https://github.com/redpanda-data/kgo-verifier.git
cd /opt/kgo-verifier
git reset --hard a4dff215149f8acb4fde8617f19adeabbfa69d44
git reset --hard fab9660131cd4e6426eda6cec93ecfe1f5c0529b
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fab9660 points to a git commit in unmerged PR redpanda-data/kgo-verifier#58. it would be best to point to the merge commit after that PR merges to main to ensure the git lineage tracks back to latest of what exists on main branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants