Adds functionality to schema_registry_decode to emit defaults or not
#2855
+182
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows zero value fields and empty strings to NOT be omitted when using `schema_registry_decode` to decode protobuf messages
Originally having a protobuf message like `{"a": 1, "b": 0}` after `schema_registry_decode` would result in `{"a": 1}`, this allows user to specify if that is the intended behaviour or not
…otojson.MarshalerOpts`
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR allows users to specify different behaviour for
schema_registry_decodewhen decodingprotobufmessages; allowing them to chose to Emit defaults.Why
if a protobuf message like
{"a": 0, "b": 1}is encoded to protobuf, when we decode withschema_registry_decodethe resulting message is{"b": 1}and the keyval"a": 0is lost.This behaviour is controlled from
protojson.MarshalerOptswith the fieldEmitDefaultValues, which by fault isfalse.