Add a panic helper for non-assert aborts. #1212
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We merged a fix for a "maybe uninitialized" warning in #1209, but there is now a potential double-free.
The reason is that when compiling with NDEBUG our assert macro becomes a no-op, meaning that execution would no longer stop after
assert(NULL)
.This commit just adds a simple panic macro which will execute regardless of whether NDEBUG is defined or not.